Integrate exact coverage scores #1470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donaim
force-pushed
the
integrate-exact-coverage
branch
from
d36fc78 to
9281401
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1470 +/- ##
==========================================
- Coverage 86.30% 85.94% -0.37%
==========================================
Files 29 29
Lines 7297 7330 +33
==========================================
+ Hits 6298 6300 +2
- Misses 999 1030 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Donaim
force-pushed
the
integrate-exact-coverage
branch
from
4bcad8b to
72fed9d
Compare
A simple, semantically invariant, change that optimizes variables lookup.
The offset field only indicates where the original alignment placed the read. Exact coverage does its own k-mer based matching independent of the alignment position. A read with offset=5 can (and should) still contribute exact coverage data wherever it matches exactly in the reference. The filter was unnecessarily discarding valid coverage information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.